Solves #27 #53
Open
Solves #27 #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I understand this is not your code, I am just wondering, maybe someone can explain if the ViewHelper really does what it is meant to do :-) Description in the comment reads:
I'd say, either the function or the description is wrong. If the description is wrong, and the ViewHelper in fact should just check, if the current user is logged-in, can't we use Fluid's existing IfAuthenticated-ViewHelper (which derives from |
Owner
|
sorry, I was mistaking in deleted comment, at least related to the changed code. |
Author
|
Yeah, sure. But that is not backward compatible :-) Better: deprecate it now, remove it in the next major release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.